Published on

Advent of Pull Requests Best Practice - Day 1

  • avatar
    Nico Prananta
Advent of Pull Requests Best Practice - Day 1

πŸŽ„βœ¨ December 1st: The Countdown to Better Pull Requests Begins!

Happy December 1st, fellow coders! πŸš€ You know what that means - we're on the home stretch to the holidays, and it's the perfect time to amp up our coding game. Each day leading up to Christmas Eve, I'll be dropping some golden nuggets of wisdom on making and reviewing Pull Requests - think of it as your advent calendar for cleaner, more efficient code! 🌟

πŸ” Today's Focus: Mastering the Art of Comments on Pull Requests

From my upcoming book (yeah, that's right, I wrote a book! πŸ“š), I want to share a sneak peek about crafting comments that are sharp, constructive, and, most importantly, respectful.

Here's the gist:

🚫 Not So Great: β€œWhy did you use threads here when there’s obviously no benefit to concurrency?”

βœ… Way Better: β€œI noticed the implementation uses a concurrency model. It seems to add complexity without clear performance perks. How about a single-threaded approach to make things sleeker without sacrificing speed?”

See the difference? It's all about keeping the focus on the code, not the coder. This small shift can make a huge impact on how your feedback is received and can turn a potentially tense review into a productive dialogue. 🀝

πŸ“– Early Bird Offer

Curious for more? Jump on the early bird special and snag your copy with a 40% discount! Get it here before the offer flies away! πŸŽ‰

Stay tuned for more tips! And remember, the best PR is the one that not only improves the code but also respects the coder. 🌟